Skip to content

[Fix] Fixing http_request open_ai_client mixin #874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Fix] Fixing http_request open_ai_client mixin #874

wants to merge 1 commit into from

Conversation

@sunishsheth2009
Copy link
Contributor

@sunishsheth2009 sunishsheth2009 commented Jan 24, 2025

What changes are proposed in this pull request?

  • [Fix] Fixing http_request open_ai_client mixin

How is this tested?

https://eng-ml-inference.staging.cloud.databricks.com/editor/notebooks/801627480376241?o=1653573648247579#command/6888661323786970

from databricks.sdk import WorkspaceClient
from databricks.sdk.service.serving import ExternalFunctionRequestHttpMethod


response = WorkspaceClient().serving_endpoints.http_request(
  conn="test_sql_slack",
  method=ExternalFunctionRequestHttpMethod.POST,
  path="/api/chat.postMessage",
  json={"channel": "C07MB25Q6H3", "text": "Hello!"},
)

response.json()
response.text
response.content
response.status_code

All the above returns the correct response

@sunishsheth2009 sunishsheth2009 force-pushed the sunish-http-request-wrapper branch from 84bf4f4 to 27da5eb Compare January 24, 2025 19:34
@sunishsheth2009 sunishsheth2009 force-pushed the sunish-http-request-wrapper branch from 27da5eb to db98e99 Compare January 24, 2025 19:39
@hectorcast-db
Copy link
Contributor

hectorcast-db commented Jan 27, 2025 •
edited
Loading

serving.py is a generated file and must not be updated manually. It must be generated after the changes are done upstream.

@sunishsheth2009 sunishsheth2009 force-pushed the sunish-http-request-wrapper branch from db98e99 to ef6f276 Compare January 27, 2025 18:14
@sunishsheth2009 sunishsheth2009 force-pushed the sunish-http-request-wrapper branch from ef6f276 to 0297a3c Compare January 27, 2025 18:18
@github-actions
Copy link

github-actions bot commented Jan 27, 2025

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/sdk-py

Inputs:

  • PR number: 874
  • Commit SHA: 0297a3cf4c8d2bb64ba88e8106865405a676410b

Checks will be approved automatically on success.

@renaudhartert-db renaudhartert-db mentioned this pull request Jan 28, 2025
Merged
@sunishsheth2009
Copy link
Contributor Author

sunishsheth2009 commented Jan 29, 2025

Closing this PR because of this: #876

github-merge-queue bot pushed a commit that referenced this pull request Jan 29, 2025
@renaudhartert-db
[Internal] Update Model Serving http_request mixin to correctly use…
5339396 
… the underlying API. (#876)

## What changes are proposed in this pull request?

This PR updates the Model Serving `http_request` function so that it
properly uses the underlying generated API.

This PR also updates the API of a few unrelated services. 

## How is this tested?

Added unit tests from PR #874
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sunishsheth2009 @hectorcast-db